[PATCH] D97427: [AMDGPU] Do not annotate an else branch if there is a kill

[Carl Ritson via Phabricator via llvm-commits]

critson added a comment.

Thank you Piotr and Matt for your comments.

Since I don't really like kills being terminators either, I am going to investigate changing that before pushing this further.
I will return to this if changing kill behaviour seem in tractable.



================
Comment at: llvm/lib/Target/AMDGPU/SIAnnotateControlFlow.cpp:187
+bool SIAnnotateControlFlow::hasKill(const BasicBlock *BB) {
+  for (const Instruction &I : *BB) {
+    if (const CallInst *CI = dyn_cast<CallInst>(&I))
----------------
piotr wrote:
> Bail out if calling convention is not CallingConv::AMDGPU_PS ?
Kills are valid in other calling conventions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97427/new/

https://reviews.llvm.org/D97427