[PATCH] D96517: [AMDGPU] Optimize SGPR to scratch spilling

Michael Liao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 22 07:47:55 PST 2021


hliao added a comment.

In D96517#2574435 <https://reviews.llvm.org/D96517#2574435>, @arsenm wrote:

> I think once we're spilling SGPRs to memory with these tricks, you've given up on performance. We just need *anything* that works, and put effort into guaranteeing we never need to do this (aside from the degenerate inline-asm case using all VGPRs). I'm not worried about getting the ideal SGPR-to-memory sequence

spill doesn't mean we give up performance, specially for large workload, spill is inevitable. the spill performance still matters.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96517/new/

https://reviews.llvm.org/D96517



More information about the llvm-commits mailing list