[PATCH] D96517: [AMDGPU] Optimize SGPR to scratch spilling

[Sebastian Neubauer via Phabricator via llvm-commits]

sebastian-ne added a comment.

In D96517#2578884 <https://reviews.llvm.org/D96517#2578884>, @hliao wrote:

> why exec mask = 0 case is a valid one, won't we already branch away once exec mask goes to zero?

That is the question it comes down to. If it is guaranteed that exec is never 0, i.e. at least one bit is always set, I’m in favor of your patch.

To have some numbers, I saw some functions spilling 30 SGPRs to scratch, so it can be more than just a one or two.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96517/new/

https://reviews.llvm.org/D96517