[PATCH] D96962: [compiler-rt/mac]: use DARWIN_osx_SYSROOT to set OSX_SYSROOT_FLAG
Nico Weber via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 19 09:53:27 PST 2021
thakis added a comment.
I tested this in a "normal" build. Should I test anything exotic? (I can't test the apple-internal things, obvsly.)
================
Comment at: compiler-rt/cmake/config-ix.cmake:372
+ set(OSX_SYSROOT_FLAG "")
+ endif()
+
----------------
kubamracek wrote:
> config-ix does a bunch of compilation attempts and flag detection above this point. I assume you've tested the change and it works fine, but I'm wondering how come that the these compilations don't need this option already set?
I guess none of them include c++ stdlib headers.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96962/new/
https://reviews.llvm.org/D96962
More information about the llvm-commits
mailing list