[PATCH] D96962: [compiler-rt/mac]: use DARWIN_osx_SYSROOT to set OSX_SYSROOT_FLAG

[Steven Wu via Phabricator via llvm-commits]

steven_wu added inline comments.


================
Comment at: compiler-rt/cmake/base-config-ix.cmake:104
 if(APPLE)
-  # On Darwin if /usr/include/c++ doesn't exist, the user probably has Xcode but
-  # not the command line tools (or is using macOS 10.14 or newer). If this is
----------------
kubamracek wrote:
> delcypher wrote:
> > Can we actually remove this? This file is actually included in two places.
> > 
> > ```
> > $ git grep base-config-ix
> > CMakeLists.txt:include(base-config-ix)
> > lib/builtins/CMakeLists.txt:  include(base-config-ix)
> > ```
> > 
> > It seems the builtins directory can be used for a standalone build. I'm not entirely sure who is using this but I suspect if you remove this code you'd probably break the standalone builtin build because it doesn't include `config-ix.cmake`.
> This is a good point. @steven_wu @arphaman ?
Sounds like a valid point. It is hard to reason about compiler_rt cmake. Might want to test all our build configurations to make sure this still works.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96962/new/

https://reviews.llvm.org/D96962