[PATCH] D96962: [compiler-rt/mac]: use DARWIN_osx_SYSROOT to set OSX_SYSROOT_FLAG

[Kuba (Brecka) Mracek via Phabricator via llvm-commits]

kubamracek added inline comments.


================
Comment at: compiler-rt/cmake/config-ix.cmake:372
+    set(OSX_SYSROOT_FLAG "")
+  endif()
+
----------------
thakis wrote:
> kubamracek wrote:
> > config-ix does a bunch of compilation attempts and flag detection above this point. I assume you've tested the change and it works fine, but I'm wondering how come that the these compilations don't need this option already set?
> I guess none of them include c++ stdlib headers.
The -isysroot flag is needed even for C headers. And for example `test_targets()` about 200 lines above is test-compiling and using stdlib.h+stdio.h.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96962/new/

https://reviews.llvm.org/D96962