[PATCH] D96671: [GlobalISel] Implement narrowScalar for UADDO/USUBO

[Cassie Jones via Phabricator via llvm-commits]

porglezomp added inline comments.


================
Comment at: llvm/unittests/CodeGen/GlobalISel/LegalizerHelperTest.cpp:898
+  auto Op1 = B.buildUndef(S96);
+  auto UADDO = B.buildInstr(TargetOpcode::G_UADDO, {S96, S1}, {Op0, Op1});
+
----------------
arsenm wrote:
> Should have a dedicated buildUAddo
I wrote it this way to match the style of the surrounding tests. Which would we prefer here, better style, or more consistency? I'm already changing some other things in favor of better style in the new tests, so I wouldn't be opposed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96671/new/

https://reviews.llvm.org/D96671