[PATCH] D96671: [GlobalISel] Implement narrowScalar for UADDO/USUBO

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/unittests/CodeGen/GlobalISel/LegalizerHelperTest.cpp:898
+  auto Op1 = B.buildUndef(S96);
+  auto UADDO = B.buildInstr(TargetOpcode::G_UADDO, {S96, S1}, {Op0, Op1});
+
----------------
porglezomp wrote:
> arsenm wrote:
> > Should have a dedicated buildUAddo
> I wrote it this way to match the style of the surrounding tests. Which would we prefer here, better style, or more consistency? I'm already changing some other things in favor of better style in the new tests, so I wouldn't be opposed.
Raw buildInstr is always uglier and only appropriate if you don't know the exact opcode you're using


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96671/new/

https://reviews.llvm.org/D96671