[PATCH] D96671: [GlobalISel] Implement narrowScalar for UADDO/USUBO

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:4485
 
+  unsigned NumDefs = MI.getNumExplicitDefs();
+  Register Src1 = MI.getOperand(NumDefs).getReg();
----------------
arsenm wrote:
> Might as well hard code the 2 here, treating it as unknown is slightly more confusing
I think this is supposed to be shared between the overflow ops/non-overflow ops, so it makes sense to not hardcode a 2.

I think a comment saying that this should be 1 or 2 would be handy though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96671/new/

https://reviews.llvm.org/D96671