[PATCH] D96455: [SampleFDO][NFC] Refactor SampleProfile.cpp

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

Thanks for taking a look @xur. Unfortunately I needed to revert this again, as `llc` is still failing to build (see c28622fbf363d8ade9598ea6ffb88cb9a8f7604f <https://reviews.llvm.org/rGc28622fbf363d8ade9598ea6ffb88cb9a8f7604f>):

  duplicate symbol 'llvm::SampleProfileLoaderBaseImpl::findEquivalenceClasses(llvm::Function&)' in:
      tools/llc/CMakeFiles/llc.dir/llc.cpp.o
      lib/libLLVMInstCombine.a(InstCombineVectorOps.cpp.o)

I believe the problem is that you have definitions like SampleProfileLoaderBaseImpl::findEquivalenceClasses that get imported into multiple TU's, then conflict at link-time. These probably need to be sunk into some .cpp and built just once (would also be better for compile time).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96455/new/

https://reviews.llvm.org/D96455