[PATCH] D96455: [SampleFDO][NFC] Refactor SampleProfile.cpp

[Rong Xu via llvm-commits]

Yes. I'm aware of this. I had a fix already. Testing it now.

-Rong

On Tue, Feb 16, 2021 at 2:23 PM Vedant Kumar via Phabricator <
reviews at reviews.llvm.org> wrote:

> vsk added a comment.
>
> Hi @xur, just a heads-up that this also appears to have introduced a
> cyclic dependency issue which broke the LLVM_ENABLE_MODULES=On build:
>
>   While building module 'LLVM_Transforms' imported from
> /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/ExecutionEngine/Orc/IndirectionUtils.h:24:
>   While building module 'LLVM_Analysis' imported from
> /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/Transforms/Coroutines/CoroSplit.h:18:
>   While building module 'LLVM_ProfileData' imported from
> /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/Analysis/IndirectCallPromotionAnalysis.h:16:
>   In file included from <module-includes>:12:
>
> /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/ProfileData/SampleProfileLoaderBaseImpl.h:24:10:
> fatal error: cyclic dependency in module 'LLVM_Analysis': LLVM_Analysis ->
> LLVM_ProfileData -> LLVM_Analysis
>   #include "llvm/Analysis/LoopInfo.h"
>
> http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/28897/consoleText
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D96455/new/
>
> https://reviews.llvm.org/D96455
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210216/4b304e32/attachment.html>