[PATCH] D96455: [SampleFDO][NFC] Refactor SampleProfile.cpp

[Rong Xu via llvm-commits]

Thanks for reporting this.
What config this failure is using? I don't see this error in my builds.
This is an intermediate step for templatelizing the code. I don't think
this will be a problem for the templated headers.

-Rong

On Wed, Feb 17, 2021 at 10:26 AM Vedant Kumar via Phabricator <
reviews at reviews.llvm.org> wrote:

> vsk added a comment.
>
> Thanks for taking a look @xur. Unfortunately I needed to revert this
> again, as `llc` is still failing to build (see
> c28622fbf363d8ade9598ea6ffb88cb9a8f7604f <
> https://reviews.llvm.org/rGc28622fbf363d8ade9598ea6ffb88cb9a8f7604f>):
>
>   duplicate symbol
> 'llvm::SampleProfileLoaderBaseImpl::findEquivalenceClasses(llvm::Function&)'
> in:
>       tools/llc/CMakeFiles/llc.dir/llc.cpp.o
>       lib/libLLVMInstCombine.a(InstCombineVectorOps.cpp.o)
>
> I believe the problem is that you have definitions like
> SampleProfileLoaderBaseImpl::findEquivalenceClasses that get imported into
> multiple TU's, then conflict at link-time. These probably need to be sunk
> into some .cpp and built just once (would also be better for compile time).
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D96455/new/
>
> https://reviews.llvm.org/D96455
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210217/a905c459/attachment.html>