[PATCH] D96455: [SampleFDO][NFC] Refactor SampleProfile.cpp

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

Hi @xur, just a heads-up that this also appears to have introduced a cyclic dependency issue which broke the LLVM_ENABLE_MODULES=On build:

  While building module 'LLVM_Transforms' imported from /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/ExecutionEngine/Orc/IndirectionUtils.h:24:
  While building module 'LLVM_Analysis' imported from /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/Transforms/Coroutines/CoroSplit.h:18:
  While building module 'LLVM_ProfileData' imported from /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/Analysis/IndirectCallPromotionAnalysis.h:16:
  In file included from <module-includes>:12:
  /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/ProfileData/SampleProfileLoaderBaseImpl.h:24:10: fatal error: cyclic dependency in module 'LLVM_Analysis': LLVM_Analysis -> LLVM_ProfileData -> LLVM_Analysis
  #include "llvm/Analysis/LoopInfo.h"

http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/28897/consoleText


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96455/new/

https://reviews.llvm.org/D96455