[PATCH] D96810: [SampleFDO] Provide a virtual desructor for SampleProfileLoaderBaseImpl

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 16 13:52:00 PST 2021


dblaikie added a comment.

Hey, sorry - my commit to fix this (making the dtor protected and default, but non-virtual) collided with this one, so I undid this one in favor of mine. (since the objects don't seem to be owned polymorphically, but concretely such as in `llvm/lib/Transforms/IPO/SampleProfile.cpp:  SampleProfileLoader SampleLoader;`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96810/new/

https://reviews.llvm.org/D96810



More information about the llvm-commits mailing list