[PATCH] D96810: [SampleFDO] Provide a virtual desructor for SampleProfileLoaderBaseImpl

Kazu Hirata via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 16 13:18:06 PST 2021


This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGba2aa5f49ebb: [SampleFDO] Provide a virtual desructor for SampleProfileLoaderBaseImpl (authored by kazu).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96810/new/

https://reviews.llvm.org/D96810

Files:
  llvm/include/llvm/ProfileData/SampleProfileLoaderBaseImpl.h


Index: llvm/include/llvm/ProfileData/SampleProfileLoaderBaseImpl.h
===================================================================
--- llvm/include/llvm/ProfileData/SampleProfileLoaderBaseImpl.h
+++ llvm/include/llvm/ProfileData/SampleProfileLoaderBaseImpl.h
@@ -69,6 +69,7 @@
 class SampleProfileLoaderBaseImpl {
 public:
   SampleProfileLoaderBaseImpl(std::string Name) : Filename(Name) {}
+  virtual ~SampleProfileLoaderBaseImpl() = default;
   void dump() { Reader->dump(); }
 
 protected:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D96810.324093.patch
Type: text/x-patch
Size: 498 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210216/9bc0f726/attachment.bin>


More information about the llvm-commits mailing list