[PATCH] D96810: [SampleFDO] Provide a virtual desructor for SampleProfileLoaderBaseImpl

[Rong Xu via llvm-commits]

No worry. This fix also works for me. Thank you and Kazu for the quick
response!  Much appreciated.

-Rong

On Tue, Feb 16, 2021 at 1:52 PM David Blaikie via Phabricator <
reviews at reviews.llvm.org> wrote:

> dblaikie added a comment.
>
> Hey, sorry - my commit to fix this (making the dtor protected and default,
> but non-virtual) collided with this one, so I undid this one in favor of
> mine. (since the objects don't seem to be owned polymorphically, but
> concretely such as in `llvm/lib/Transforms/IPO/SampleProfile.cpp:
> SampleProfileLoader SampleLoader;`
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D96810/new/
>
> https://reviews.llvm.org/D96810
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210216/0485a117/attachment.html>