[PATCH] D96810: [SampleFDO] Provide a virtual desructor for SampleProfileLoaderBaseImpl
Rong Xu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 16 13:06:59 PST 2021
xur accepted this revision.
xur added a comment.
This revision is now accepted and ready to land.
Thanks for fixing this. I think this is fine. I don't think there will a direct allocation of the base type. We always use the derived type to allocate the object.
Samples field will be freed by the Reader which is an uniqe_pointer.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96810/new/
https://reviews.llvm.org/D96810
More information about the llvm-commits
mailing list