[PATCH] D96553: [NFC] Combine runNewPMPasses() and runNewPMCustomPasses()

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/lib/LTO/LTOBackend.cpp:211
                            const ModuleSummaryIndex *ImportSummary) {
   Optional<PGOOptions> PGOOpt;
   if (!Conf.SampleProfile.empty())
----------------
tejohnson wrote:
> Will setting the PGOOpt and passing down to the PassBuilder cause an issue for the custom case?
AFAICT the custom passes is mostly for experimenting with new custom pass pipelines, not the default pipelines that `PassBuilder` provides. `PGOOpt` is only used for `PassBuilder`'s default pipelines.
Also there aren't a lot of tests that use it, and I think that the custom pipeline is not really used much in practice.

I guess what I'm saying is I'm not sure if this is really used and I'm don't think that it'll matter a lot.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96553/new/

https://reviews.llvm.org/D96553