[PATCH] D96553: [NFC] Combine runNewPMPasses() and runNewPMCustomPasses()
Teresa Johnson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 11 18:50:16 PST 2021
tejohnson added a comment.
In D96553#2558797 <https://reviews.llvm.org/D96553#2558797>, @aeubanks wrote:
> In D96553#2558668 <https://reviews.llvm.org/D96553#2558668>, @tejohnson wrote:
>
>> Looks like a great cleanup! One question below.
>
> I don't see any comments
Weird, I guess I neglected to save it. Added it below.
================
Comment at: llvm/lib/LTO/LTOBackend.cpp:211
const ModuleSummaryIndex *ImportSummary) {
Optional<PGOOptions> PGOOpt;
if (!Conf.SampleProfile.empty())
----------------
Will setting the PGOOpt and passing down to the PassBuilder cause an issue for the custom case?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96553/new/
https://reviews.llvm.org/D96553
More information about the llvm-commits
mailing list