[PATCH] D96553: [NFC] Combine runNewPMPasses() and runNewPMCustomPasses()
Teresa Johnson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 12 16:18:13 PST 2021
tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.
lgtm
================
Comment at: llvm/lib/LTO/LTOBackend.cpp:211
const ModuleSummaryIndex *ImportSummary) {
Optional<PGOOptions> PGOOpt;
if (!Conf.SampleProfile.empty())
----------------
aeubanks wrote:
> tejohnson wrote:
> > Will setting the PGOOpt and passing down to the PassBuilder cause an issue for the custom case?
> AFAICT the custom passes is mostly for experimenting with new custom pass pipelines, not the default pipelines that `PassBuilder` provides. `PGOOpt` is only used for `PassBuilder`'s default pipelines.
> Also there aren't a lot of tests that use it, and I think that the custom pipeline is not really used much in practice.
>
> I guess what I'm saying is I'm not sure if this is really used and I'm don't think that it'll matter a lot.
Ok. I'm going to assume that if one of these PGO types is enabled in the Config, that it should be honored. And if different behavior is desired, someone should put in a test for it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96553/new/
https://reviews.llvm.org/D96553
More information about the llvm-commits
mailing list