[PATCH] D96469: [AMDGPU] WIP: use single cache policy operand

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 11 02:02:04 PST 2021


rampitec added a comment.

In D96469#2556038 <https://reviews.llvm.org/D96469#2556038>, @t-tye wrote:

> In D96469#2555786 <https://reviews.llvm.org/D96469#2555786>, @rampitec wrote:
>
>> Another question, can we have a shorter name than "cache_policy"? "cpol" maybe? It blows formatting in many places.
>
> What about "cp"? We have "as" I think for address space.

Ack. Also note, it will never appear in asm, only in compiler sources.

In D96469#2556104 <https://reviews.llvm.org/D96469#2556104>, @rampitec wrote:

> In D96469#2556038 <https://reviews.llvm.org/D96469#2556038>, @t-tye wrote:
>
>> In D96469#2555786 <https://reviews.llvm.org/D96469#2555786>, @rampitec wrote:
>>
>>> Another question, can we have a shorter name than "cache_policy"? "cpol" maybe? It blows formatting in many places.
>>
>> What about "cp"? We have "as" I think for address space.
>
> Ack. Also note, it will never appear in asm, only in compiler sources.



In D96469#2556104 <https://reviews.llvm.org/D96469#2556104>, @rampitec wrote:

> In D96469#2556038 <https://reviews.llvm.org/D96469#2556038>, @t-tye wrote:
>
>> In D96469#2555786 <https://reviews.llvm.org/D96469#2555786>, @rampitec wrote:
>>
>>> Another question, can we have a shorter name than "cache_policy"? "cpol" maybe? It blows formatting in many places.
>>
>> What about "cp"? We have "as" I think for address space.
>
> Ack. Also note, it will never appear in asm, only in compiler sources.



In D96469#2556038 <https://reviews.llvm.org/D96469#2556038>, @t-tye wrote:

> In D96469#2555786 <https://reviews.llvm.org/D96469#2555786>, @rampitec wrote:
>
>> Another question, can we have a shorter name than "cache_policy"? "cpol" maybe? It blows formatting in many places.
>
> What about "cp"? We have "as" I think for address space.

I still cannot get rid of the connotations to 'cp' command. CPol looks less misleading to me.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96469/new/

https://reviews.llvm.org/D96469



More information about the llvm-commits mailing list