[PATCH] D96469: [AMDGPU] WIP: use single cache policy operand

[Dmitry Preobrazhensky via Phabricator via llvm-commits]

dp added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:4876
+  // since parseOptionalOperand just consumed all of the individual bits.
+  if (ResTy == MatchOperand_Success && Mnemonic.startswith("scratch_")) {
+    unsigned CPPos = 0;
----------------
rampitec wrote:
> arsenm wrote:
> > Don't see why this needs to check the mnemonic, but I guess that's part of the temporary hack
> Yes, it is hack to only change small number of instructions for now.
It would be interesting to add global_ to play with hardcoded glc.


================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:6919
+    } else if (Op.Type == AMDGPUOperand::ImmTyCachePolicy) {
+      continue;
     } else {
----------------
Maybe it would be cleaner to parse this as a real sequence of operands instead of replacing parsed operands later?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96469/new/

https://reviews.llvm.org/D96469