[PATCH] D96469: [AMDGPU] WIP: use single cache policy operand
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 10 16:47:42 PST 2021
arsenm added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:4876
+ // since parseOptionalOperand just consumed all of the individual bits.
+ if (ResTy == MatchOperand_Success && Mnemonic.startswith("scratch_")) {
+ unsigned CPPos = 0;
----------------
Don't see why this needs to check the mnemonic, but I guess that's part of the temporary hack
================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:6835
{"slc", AMDGPUOperand::ImmTySLC, true, nullptr},
+ {"cache_policy", AMDGPUOperand::ImmTyCachePolicy, false, nullptr},
{"swz", AMDGPUOperand::ImmTySWZ, true, nullptr},
----------------
i don't think anything with cache_policy in the string should be accepted, should have test to make sure
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96469/new/
https://reviews.llvm.org/D96469
More information about the llvm-commits
mailing list