[PATCH] D96469: [AMDGPU] WIP: use single cache policy operand

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 10 16:37:00 PST 2021


rampitec created this revision.
rampitec added reviewers: dp, arsenm.
Herald added subscribers: kerbowa, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl.
rampitec requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

This is WIP and incomplete. A pilot change to discuss if we want this or not.

I am proposing to replace individual operands GLC, SLC, and DLC with a single
cache_policy bitmask operand. This will reduce the number of operands in MIR
and I hope the amount of code. These operands are mostly 0 anyway.

Additional advantage that parser will accept these flags in any order unlike
now.

Selection is not done yet and only scratch instructions covered. It passes
check-llvm-mc though (but does not pass codegen tests of course).


https://reviews.llvm.org/D96469

Files:
  llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
  llvm/lib/Target/AMDGPU/FLATInstructions.td
  llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUInstPrinter.cpp
  llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUInstPrinter.h
  llvm/lib/Target/AMDGPU/SIDefines.h
  llvm/lib/Target/AMDGPU/SIInstrInfo.td

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D96469.322858.patch
Type: text/x-patch
Size: 11717 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210211/f55d1ed9/attachment.bin>


More information about the llvm-commits mailing list