[PATCH] D85036: [llvm-cov] reset executation count to 0 after wrapped segment

Zequan Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 8 16:43:30 PST 2021


zequanwu added a comment.

> I think it makes sense to revert, assuming the clang frontend bugs are fixed? It may be necessary to regenerate the .covmapping file for the instrprof-comdat.h test.

No fixes on clang coverage frontend yet :(. Reverting this will reintroduce the three bugs, and that's what I am concerned. Or revert it only after fixing it on clang coverage?

BTW, what's your opinion on the coverage bug (introduced by this change) on the description of https://reviews.llvm.org/D95987. Should line 5 be marked as executed in line coverage? I think it should.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85036/new/

https://reviews.llvm.org/D85036



More information about the llvm-commits mailing list