[PATCH] D85036: [llvm-cov] reset executation count to 0 after wrapped segment

Tue Feb 9 08:32:31 PST 2021

vsk added a comment.

In D85036#2549977 <https://reviews.llvm.org/D85036#2549977>, @zequanwu wrote:

>> I think it makes sense to revert, assuming the clang frontend bugs are fixed? It may be necessary to regenerate the .covmapping file for the instrprof-comdat.h test.
>
> No fixes on clang coverage frontend yet :(. Reverting this will reintroduce the three bugs, and that's what I am concerned. Or revert it only after fixing it on clang coverage?

I see. Usually the policy is to not knowingly regress functionality. In this case I think there's more than one reasonable way to handle things though (seeing as D85036 <https://reviews.llvm.org/D85036> seems to have caused some issues of its own). Happy to defer to your preference - if you revert this before getting around to the clang frontend bugs, please update the referenced bugzilla entries.

> BTW, what's your opinion on the coverage bug (introduced by this change) on the description of https://reviews.llvm.org/D95987. Should line 5 be marked as executed in line coverage? I think it should.

I agree.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85036/new/

https://reviews.llvm.org/D85036