[PATCH] D85036: [llvm-cov] reset executation count to 0 after wrapped segment

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 8 16:13:12 PST 2021


vsk added a comment.

IIUC, this change makes it so that the wrapped segment count isn't used on a line that starts a new region. I suppose we might prefer the wrapped count in some cases, e.g. in:

  1| if (..) {
  2|   a ? b : c; // "b" is a new region, but the wrapped count from line 1 is better for line 2 than the count from the "b" region.

In my comment from Aug. 2020, I think I mistakenly assumed that there'd be some region-entry segment on a line matching the wrapped count.

I think it makes sense to revert, assuming the clang frontend bugs are fixed? It may be necessary to regenerate the .covmapping file for the instrprof-comdat.h test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85036/new/

https://reviews.llvm.org/D85036



More information about the llvm-commits mailing list