[PATCH] D95823: [SampleFDO][NFC] Detach SampleProfileLoader from SampleCoverageTracker

Wei Mi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 1 16:43:39 PST 2021


wmi added a comment.

In D95823#2535255 <https://reviews.llvm.org/D95823#2535255>, @xur wrote:

> Machine level profile loader will use the SampleCoverage Tracker. This
> class will be kept in the templated header. Machine level profile loader
> and IR level profile loader will be using the exactly the same class (not
> templatelized).

I see. During profile annotation in machine IR level, for FunctionSamples only using base discriminator, will they be used for annotation again or their annotation will be skipped? I am asking because I am wondering what the coverage report will look like for SampleCoverageTracker used in machine IR.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95823/new/

https://reviews.llvm.org/D95823



More information about the llvm-commits mailing list