[PATCH] D95823: [SampleFDO][NFC] Detach SampleProfileLoader from SampleCoverageTracker

[Rong Xu via llvm-commits]

On Mon, Feb 1, 2021 at 4:43 PM Wei Mi via Phabricator <
reviews at reviews.llvm.org> wrote:

> wmi added a comment.
>
> In D95823#2535255 <https://reviews.llvm.org/D95823#2535255>, @xur wrote:
>
> > Machine level profile loader will use the SampleCoverage Tracker. This
> > class will be kept in the templated header. Machine level profile loader
> > and IR level profile loader will be using the exactly the same class (not
> > templatelized).
>
> I see. During profile annotation in machine IR level, for FunctionSamples
> only using base discriminator, will they be used for annotation again or
> their annotation will be skipped? I am asking because I am wondering what
> the coverage report will look like for SampleCoverageTracker used in
> machine IR.
>
Discriminator change will be in a later patch. When I introduce the Machine
level sample loader, I will add new fields in SampleProfileLoader that
specify discriminator bits being used. SampleCovergeTracker does not need
to know the bits -- samples will be handled in FunctionSamples level (i.e.
in SampleProfileLoader).


>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D95823/new/
>
> https://reviews.llvm.org/D95823
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210202/ed7cc971/attachment.html>