[PATCH] D95823: [SampleFDO][NFC] Detach SampleProfileLoader from SampleCoverageTracker

Rong Xu via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 1 16:11:34 PST 2021


Machine level profile loader will use the SampleCoverage Tracker. This
class will be kept in the templated header. Machine level profile loader
and IR level profile loader will be using the exactly the same class (not
templatelized).

On Mon, Feb 1, 2021 at 4:01 PM Wei Mi via Phabricator <
reviews at reviews.llvm.org> wrote:

> wmi added a comment.
>
> > This patch detaches SampleProfileLoader from SampleCoverageTracker. This
> would keep SampleCoverageTracker as a class.
>
> It means you don't want SampleCoverageTracker to be a template. Will the
> FS profile annotation in machine code level also need some coverage tracker?
>
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D95823/new/
>
> https://reviews.llvm.org/D95823
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210201/9cb94b37/attachment.html>


More information about the llvm-commits mailing list