[PATCH] D95690: [LoopVectorize] improve IR fast-math-flags propagation in reductions

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 1 09:32:18 PST 2021


dmgreen added a subscriber: nikic.
dmgreen added a comment.

> I think there was some problem dealing with the intrinsics in SDAG, but I don't remember the details. cc'ing @aemerson @RKSimon @craig.topper for a better answer.

I think that might have been true originally, but I believe @nikic improved things significantly with the lowering in ISel. I'm not sure if there were other issues, but it seems like it should be viable - and possibly more efficient to do the lowering in ISel. It's only expanding an instruction after all. ISel is pretty good at that kind of thing!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95690/new/

https://reviews.llvm.org/D95690



More information about the llvm-commits mailing list