[PATCH] D95428: [ARM] Add MVE insert-of-extract pattern

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:1857
+            (v4i32 (COPY_TO_REGCLASS (INSERT_SUBREG (v4f32 (COPY_TO_REGCLASS (v4i32 MQPR:$src1), MQPR)),
+                                                    (f32 (EXTRACT_SUBREG (v4f32 (COPY_TO_REGCLASS (v4i32 MQPR:$src2), MQPR)),
+                                                                         (SSubReg_f32_reg imm:$extlane))),
----------------
SjoerdMeijer wrote:
> Nit: looks like there is a precedent above, and that this is exceeding 80 columns.
Oof. I was worried you were going to say something like that. Some of these patterns do not fit well into 80 lines. I'll see what I can do.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95428/new/

https://reviews.llvm.org/D95428