[PATCH] D95428: [ARM] Add MVE insert-of-extract pattern

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 26 05:16:45 PST 2021


SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

Looks like a nice change to me.



================
Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:1857
+            (v4i32 (COPY_TO_REGCLASS (INSERT_SUBREG (v4f32 (COPY_TO_REGCLASS (v4i32 MQPR:$src1), MQPR)),
+                                                    (f32 (EXTRACT_SUBREG (v4f32 (COPY_TO_REGCLASS (v4i32 MQPR:$src2), MQPR)),
+                                                                         (SSubReg_f32_reg imm:$extlane))),
----------------
Nit: looks like there is a precedent above, and that this is exceeding 80 columns.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95428/new/

https://reviews.llvm.org/D95428



More information about the llvm-commits mailing list