[PATCH] D95428: [ARM] Add MVE insert-of-extract pattern

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 26 09:42:55 PST 2021


SjoerdMeijer added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:1857
+            (v4i32 (COPY_TO_REGCLASS (INSERT_SUBREG (v4f32 (COPY_TO_REGCLASS (v4i32 MQPR:$src1), MQPR)),
+                                                    (f32 (EXTRACT_SUBREG (v4f32 (COPY_TO_REGCLASS (v4i32 MQPR:$src2), MQPR)),
+                                                                         (SSubReg_f32_reg imm:$extlane))),
----------------
dmgreen wrote:
> SjoerdMeijer wrote:
> > Nit: looks like there is a precedent above, and that this is exceeding 80 columns.
> Oof. I was worried you were going to say something like that. Some of these patterns do not fit well into 80 lines. I'll see what I can do.
Well, do we actually have a coding style for tablegen? 
Perhaps this is clearer than breaking it up and there's enough prior art, so perhaps ignore this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95428/new/

https://reviews.llvm.org/D95428



More information about the llvm-commits mailing list