[PATCH] D86644: [llvm-mca] Initial implementation of output serialization using JSON

Wolfgang Pieb via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 21 17:35:45 PST 2021


wolfgangp added a comment.

In D86644#2514125 <https://reviews.llvm.org/D86644#2514125>, @GMNGeoffrey wrote:

> In D86644#2513914 <https://reviews.llvm.org/D86644#2513914>, @wolfgangp wrote:
>
>> In D86644#2513898 <https://reviews.llvm.org/D86644#2513898>, @GMNGeoffrey wrote:
>>
>>> FYI I'm seeing clang diagnostic errors, I think from this commit:
>>
>> Should be fixed now.
>
> I'm still seeing some. Looks like your fix didn't get all of them:

Sorry about that. Should be all of them now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86644/new/

https://reviews.llvm.org/D86644



More information about the llvm-commits mailing list