[PATCH] D86644: [llvm-mca] Initial implementation of output serialization using JSON

[Geoffrey Martin-Noble via Phabricator via llvm-commits]

GMNGeoffrey added a comment.

In D86644#2513914 <https://reviews.llvm.org/D86644#2513914>, @wolfgangp wrote:

> In D86644#2513898 <https://reviews.llvm.org/D86644#2513898>, @GMNGeoffrey wrote:
>
>> FYI I'm seeing clang diagnostic errors, I think from this commit:
>
> Should be fixed now.

I'm still seeing some. Looks like your fix didn't get all of them:

> Views/InstructionInfoView.h:81:15: error: 'toJSON' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
>
>   json::Value toJSON() const;
>               ^
>
> Views/InstructionView.h:58:15: note: overridden virtual function is here
>
>   json::Value toJSON() const override;




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86644/new/

https://reviews.llvm.org/D86644