[PATCH] D86644: [llvm-mca] Initial implementation of output serialization using JSON

[Geoffrey Martin-Noble via Phabricator via llvm-commits]

GMNGeoffrey added a comment.

In D86644#2514142 <https://reviews.llvm.org/D86644#2514142>, @wolfgangp wrote:

> In D86644#2514125 <https://reviews.llvm.org/D86644#2514125>, @GMNGeoffrey wrote:
>
>> In D86644#2513914 <https://reviews.llvm.org/D86644#2513914>, @wolfgangp wrote:
>>
>>> In D86644#2513898 <https://reviews.llvm.org/D86644#2513898>, @GMNGeoffrey wrote:
>>>
>>>> FYI I'm seeing clang diagnostic errors, I think from this commit:
>>>
>>> Should be fixed now.
>>
>> I'm still seeing some. Looks like your fix didn't get all of them:
>
> Sorry about that. Should be all of them now.

Thanks! Looks good on my end now :-) Really wish some premerge checks ran with these on... :-/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86644/new/

https://reviews.llvm.org/D86644