[PATCH] D94766: Add lit env variable to disable indirect checks

Joel E. Denny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 21 10:31:00 PST 2021


jdenny added a comment.

So the lit invocations are in a script of some sort, right?  Such a script could perform a feature test to handle this use case: if `--no-indirectly-run-check` is supported, add it to some lit options variable used by all relevant lit invocations in the script, and do not otherwise.  Is that difficult to do?

I'm not strongly opposed to this patch, especially if it helps many people.  However, given that this use case is external and temporary, I'm inclined to think a feature test is more reasonable: it's also simple, but it's external like the use case and can be dropped by users when they decide they no longer need to support old lit versions.  What do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94766/new/

https://reviews.llvm.org/D94766



More information about the llvm-commits mailing list