[PATCH] D94766: Add lit env variable to disable indirect checks

Julian Lettner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 21 11:09:04 PST 2021


yln added a comment.

In D94766#2513022 <https://reviews.llvm.org/D94766#2513022>, @jdenny wrote:

> I'm not strongly opposed to this patch, especially if it helps many people.  However, given that this use case is external and temporary, I'm inclined to think a feature test is more reasonable: it's also simple, but it's external like the use case and can be dropped by users when they decide they no longer need to support old lit versions.  What do you think?

+1

I feel the same as Joel.  Not opposed, but my default stance is to try to avoid collecting and codifying workarounds.  They almost never get removed once obsolete.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94766/new/

https://reviews.llvm.org/D94766



More information about the llvm-commits mailing list