[PATCH] D94766: Add lit env variable to disable indirect checks

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre added a comment.

In D94766#2512681 <https://reviews.llvm.org/D94766#2512681>, @jdenny wrote:

> Can you explain the use case a bit more?  I don't find myself moving between old and new versions of lit very often.  Perhaps I'm naive, but it seems like it should be easy enough to just not specify `--no-indirectly-run-check` when using the old version.

Our systems use a mix of LLVM versions (whatever is available on that OS). This causes problem for this option because tests are run individually using lit (tests are managed by CTest which runs lit) and thus require the --no-indirect-run-check option to not fail due to warning but then systems with an old lit fail because the option is not accepted. Having a variable would allow to support a nice mix. It also allows to upgrade to a newer lit without having to update lit and the tests in lockstep.

The problem of --no-indirectly-run-check is it changes the behavior of lit. This is fine in LLVM but lit is used outside of LLVM and I think we should acknowledge that and aim to maintain compatibility to some degree (if cost is low, it should not become a burden to LLVM). The environment variable allow a smooth migration from one version to the next (and a mix of version in our case). A lit configuration option would work as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94766/new/

https://reviews.llvm.org/D94766