[PATCH] D94345: [SPARC] Fix fp128 load/stores
LemonBoy via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 8 15:22:28 PST 2021
LemonBoy created this revision.
LemonBoy added reviewers: jrtc27, venkataramanan.kumar.llvm, jyknight, joerg, dcederman.
Herald added subscribers: fedor.sergeev, hiraditya.
LemonBoy requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
The generated code for the split fp128 load/stores was missing a small yet important adjustment to the pointer metadata being fed into `getStore` and `getLoad`, making it out of sync with the effective memory address.
This problem often resulted in instructions being scheduled in the wrong order.
I also took this chance to clean up some "wrong" uses of `getAlignment` as done in D77687 <https://reviews.llvm.org/D77687>.
Thanks @jrtc27 for finding the problem and providing a patch.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D94345
Files:
llvm/lib/Target/Sparc/SparcISelLowering.cpp
llvm/test/CodeGen/SPARC/fp128-split.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D94345.315530.patch
Type: text/x-patch
Size: 4916 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210108/ba6bbad4/attachment.bin>
More information about the llvm-commits
mailing list