[PATCH] D94345: [SPARC] Fix fp128 load/stores

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/Sparc/SparcISelLowering.cpp:2734
   SDLoc dl(Op);
   LoadSDNode *LdNode = dyn_cast<LoadSDNode>(Op.getNode());
   assert(LdNode && LdNode->getOffset().isUndef()
----------------
This dyn_cast is only checked by the assert below. The rest of the code just blindly dereferences it.


================
Comment at: llvm/lib/Target/Sparc/SparcISelLowering.cpp:2787
   SDLoc dl(Op);
   StoreSDNode *StNode = dyn_cast<StoreSDNode>(Op.getNode());
   assert(StNode && StNode->getOffset().isUndef()
----------------
Same here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94345/new/

https://reviews.llvm.org/D94345