[PATCH] D94333: [Inliner] Change inline remark format

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 8 13:56:22 PST 2021

Previous message: [PATCH] D94333: [Inliner] Change inline remark format
Next message: [PATCH] D94333: [Inliner] Change inline remark format
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

davidxl added a comment.

The proposal in the patch is to use line:col.discriminator (which is reasonable), but the implementation uses line:col:discriminator -- please update the patch to be consistent.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94333/new/

https://reviews.llvm.org/D94333

Previous message: [PATCH] D94333: [Inliner] Change inline remark format
Next message: [PATCH] D94333: [Inliner] Change inline remark format
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list