[PATCH] D94333: [Inliner] Change inline remark format

Francis Visoiu Mistrih via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 8 12:43:54 PST 2021


thegameg added inline comments.


================
Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:418
       Name = DIL->getScope()->getSubprogram()->getName();
-    Remark << Name << ":" << ore::NV("Line", Offset);
+    Remark << Name << ":" << ore::NV("Line", Offset) << ":"
+           << ore::NV("Column", DIL->getColumn());
----------------
Can we use a `DebugLoc` here like `Callee` and `Caller`?

Something like:

```
- String: 'at callsite '
- CallSite: bar
  DebugLoc: { File: '/tmp/s.c', Line: 1, Column: 10 }
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94333/new/

https://reviews.llvm.org/D94333



More information about the llvm-commits mailing list