[PATCH] D94333: [Inliner] Change inline remark format

[Wenlei He via Phabricator via llvm-commits]

wenlei added inline comments.


================
Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:418
       Name = DIL->getScope()->getSubprogram()->getName();
-    Remark << Name << ":" << ore::NV("Line", Offset);
+    Remark << Name << ":" << ore::NV("Line", Offset) << ":"
+           << ore::NV("Column", DIL->getColumn());
----------------
thegameg wrote:
> Can we use a `DebugLoc` here like `Callee` and `Caller`?
> 
> Something like:
> 
> ```
> - String: 'at callsite '
> - CallSite: bar
>   DebugLoc: { File: '/tmp/s.c', Line: 1, Column: 10 }
> ```
Having location in text output as well (in addition to yaml) makes it easier to consume for replay. If we go with what Caller/Callee use, I guess the location only goes to yaml, but not text remarks?

As for the format of location string in text mark, the current form aligns with the context representation of CSSPGO's profile, so it makes things a bit easier for inlining related investigation, etc, which is intended use case for inline replay scaffolding.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94333/new/

https://reviews.llvm.org/D94333