[PATCH] D94024: [RISCV] Clear isCodeGenOnly flag on VMSGE(U) pseudo instructions. Remove InstAliases that duplicate the asm strings in the pseudos.

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 7 02:09:27 PST 2021


frasercrmck added a comment.

Sorry, haven't felt able to review this as I don't get the original problem well enough. Because it looks to me like the aliases //permitted// matches, e.g. `vmsgeu.vx $vd, $va, $rs1` which wasn't matching because it was unmasked? It's just that the comment says the "alias .. //prevents// matching" which throws me off as that's the opposite of what I thought they were for.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94024/new/

https://reviews.llvm.org/D94024



More information about the llvm-commits mailing list