[PATCH] D93312: [RISCV] Add ISel support for RVV .vx and .vi forms

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck marked an inline comment as done.
frasercrmck added a comment.

In D93312#2466767 <https://reviews.llvm.org/D93312#2466767>, @craig.topper wrote:

> Would it make sense to move the SDNode patterns and their helpers to a different file. They use the pseudos but are otherwise independent. I worry that RISCVInstrInfoVPseudos.td is going to become very large and this might be a logical piece to split out.

Could do. I agree the file is going to get unwieldy. However I'd personally find it a bit odd if the RISCVInstrInfoVPseudos.td file contains the pseudos and the intrinsic patterns but not the SDNode patterns. Maybe that's because I view the SDNode support as more "first-class" than intrinsics. I'm assuming you're saying "SDNode" here as opposed to intrinsics, because the intrinsics are technically SDNodes. We just don't have a better terminology.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93312/new/

https://reviews.llvm.org/D93312