[PATCH] D93487: [RISCV] Sign extend constant arguments to V intrinsics when promoting to XLen.

[Roger Ferrer Ibanez via Phabricator via llvm-commits]

rogfer01 added a comment.

> For instructions that use a uimm5 immediate, this change only affects
> constants >= 128 for i8 or >= 32768 for i16. Constants that large
> already wouldn't have been eligible for uimm5 and would need to use a
> scalar register.

Just to make sure I understand this case, this is relevant for negative numbers which at this point of the backend just look like like very large constants (up to XLenVT).

Other than that, LGTM. Thanks @craig.topper


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93487/new/

https://reviews.llvm.org/D93487