[PATCH] D93254: [NFC][SampleFDO] Preparation to support multiple sections with the same type in ExtBinary format.

[Wei Mi via llvm-commits]

Thanks to Simon Pilgrim who helped to fix it at
https://reviews.llvm.org/rG4bb10be9a6e06a6c51cc1695ff5dc9d68c953334.

On Thu, Dec 17, 2020 at 6:04 AM Matt Morehouse via Phabricator <
reviews at reviews.llvm.org> wrote:

> morehouse added a comment.
>
> In D93254#2459721 <https://reviews.llvm.org/D93254#2459721>,
> @steven.zhang wrote:
>
> > The new added field `LayoutIndex` miss to be initialized in
> `include/llvm/ProfileData/SampleProfWriter.h:281` which cause the
> compiler(clang) warning if with option `-Wmissing-field-initializers`.
> > This is the error message:
> >  error: missing field 'LayoutIndex' initializer
> [-Werror,-Wmissing-field-initializers]
>
> Yes, the bots are failing.  Please fix or revert.
> http://lab.llvm.org:8011/#/builders/77/builds/2124
>
>   In file included from
> /var/lib/buildbot/sanitizer-buildbot6/sanitizer-x86_64-linux-android/build/llvm-project/llvm/tools/llvm-profdata/llvm-profdata.cpp:21:
>
> /var/lib/buildbot/sanitizer-buildbot6/sanitizer-x86_64-linux-android/build/llvm-project/llvm/include/llvm/ProfileData/SampleProfWriter.h:281:33:
> error: missing field 'LayoutIndex' initializer
> [-Werror,-Wmissing-field-initializers]
>           {SecProfSummary, 0, 0, 0},       {SecNameTable, 0, 0, 0},
>                                   ^
>
> /var/lib/buildbot/sanitizer-buildbot6/sanitizer-x86_64-linux-android/build/llvm-project/llvm/include/llvm/ProfileData/SampleProfWriter.h:281:64:
> error: missing field 'LayoutIndex' initializer
> [-Werror,-Wmissing-field-initializers]
>           {SecProfSummary, 0, 0, 0},       {SecNameTable, 0, 0, 0},
>                                                                  ^
>
> /var/lib/buildbot/sanitizer-buildbot6/sanitizer-x86_64-linux-android/build/llvm-project/llvm/include/llvm/ProfileData/SampleProfWriter.h:282:37:
> error: missing field 'LayoutIndex' initializer
> [-Werror,-Wmissing-field-initializers]
>           {SecFuncOffsetTable, 0, 0, 0},   {SecLBRProfile, 0, 0, 0},
>                                       ^
>
> /var/lib/buildbot/sanitizer-buildbot6/sanitizer-x86_64-linux-android/build/llvm-project/llvm/include/llvm/ProfileData/SampleProfWriter.h:282:65:
> error: missing field 'LayoutIndex' initializer
> [-Werror,-Wmissing-field-initializers]
>           {SecFuncOffsetTable, 0, 0, 0},   {SecLBRProfile, 0, 0, 0},
>                                                                   ^
>
> /var/lib/buildbot/sanitizer-buildbot6/sanitizer-x86_64-linux-android/build/llvm-project/llvm/include/llvm/ProfileData/SampleProfWriter.h:283:39:
> error: missing field 'LayoutIndex' initializer
> [-Werror,-Wmissing-field-initializers]
>           {SecProfileSymbolList, 0, 0, 0}, {SecFuncMetadata, 0, 0, 0}};
>                                         ^
>
> /var/lib/buildbot/sanitizer-buildbot6/sanitizer-x86_64-linux-android/build/llvm-project/llvm/include/llvm/ProfileData/SampleProfWriter.h:283:67:
> error: missing field 'LayoutIndex' initializer
> [-Werror,-Wmissing-field-initializers]
>           {SecProfileSymbolList, 0, 0, 0}, {SecFuncMetadata, 0, 0, 0}};
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D93254/new/
>
> https://reviews.llvm.org/D93254
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201217/2a55bc14/attachment.html>