[PATCH] D93254: [NFC][SampleFDO] Preparation to support multiple sections with the same type in ExtBinary format.

Thu Dec 17 06:04:56 PST 2020

morehouse added a comment.

In D93254#2459721 <https://reviews.llvm.org/D93254#2459721>, @steven.zhang wrote:

> The new added field `LayoutIndex` miss to be initialized in `include/llvm/ProfileData/SampleProfWriter.h:281` which cause the compiler(clang) warning if with option `-Wmissing-field-initializers`.
> This is the error message:
>  error: missing field 'LayoutIndex' initializer [-Werror,-Wmissing-field-initializers]

Yes, the bots are failing.  Please fix or revert.  http://lab.llvm.org:8011/#/builders/77/builds/2124

  In file included from /var/lib/buildbot/sanitizer-buildbot6/sanitizer-x86_64-linux-android/build/llvm-project/llvm/tools/llvm-profdata/llvm-profdata.cpp:21:
  /var/lib/buildbot/sanitizer-buildbot6/sanitizer-x86_64-linux-android/build/llvm-project/llvm/include/llvm/ProfileData/SampleProfWriter.h:281:33: error: missing field 'LayoutIndex' initializer [-Werror,-Wmissing-field-initializers]
          {SecProfSummary, 0, 0, 0},       {SecNameTable, 0, 0, 0},
                                  ^
  /var/lib/buildbot/sanitizer-buildbot6/sanitizer-x86_64-linux-android/build/llvm-project/llvm/include/llvm/ProfileData/SampleProfWriter.h:281:64: error: missing field 'LayoutIndex' initializer [-Werror,-Wmissing-field-initializers]
          {SecProfSummary, 0, 0, 0},       {SecNameTable, 0, 0, 0},
                                                                 ^
  /var/lib/buildbot/sanitizer-buildbot6/sanitizer-x86_64-linux-android/build/llvm-project/llvm/include/llvm/ProfileData/SampleProfWriter.h:282:37: error: missing field 'LayoutIndex' initializer [-Werror,-Wmissing-field-initializers]
          {SecFuncOffsetTable, 0, 0, 0},   {SecLBRProfile, 0, 0, 0},
                                      ^
  /var/lib/buildbot/sanitizer-buildbot6/sanitizer-x86_64-linux-android/build/llvm-project/llvm/include/llvm/ProfileData/SampleProfWriter.h:282:65: error: missing field 'LayoutIndex' initializer [-Werror,-Wmissing-field-initializers]
          {SecFuncOffsetTable, 0, 0, 0},   {SecLBRProfile, 0, 0, 0},
                                                                  ^
  /var/lib/buildbot/sanitizer-buildbot6/sanitizer-x86_64-linux-android/build/llvm-project/llvm/include/llvm/ProfileData/SampleProfWriter.h:283:39: error: missing field 'LayoutIndex' initializer [-Werror,-Wmissing-field-initializers]
          {SecProfileSymbolList, 0, 0, 0}, {SecFuncMetadata, 0, 0, 0}};
                                        ^
  /var/lib/buildbot/sanitizer-buildbot6/sanitizer-x86_64-linux-android/build/llvm-project/llvm/include/llvm/ProfileData/SampleProfWriter.h:283:67: error: missing field 'LayoutIndex' initializer [-Werror,-Wmissing-field-initializers]
          {SecProfileSymbolList, 0, 0, 0}, {SecFuncMetadata, 0, 0, 0}};

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93254/new/

https://reviews.llvm.org/D93254